RDKEMW-17937 : remove ctrlm build flags - IP_ENABLED - #253
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Removes the (now-unused) IP HAL build toggle and associated IP HAL header/API references from Control Manager, along with corresponding documentation/build script updates.
Changes:
- Removes the
IP_ENABLEDCMake option and its related compile definitions. - Eliminates remaining includes/usages of the IP HAL header/types and deletes
include/ctrlm_hal_ip.h. - Updates Doxygen configuration and doc build script to stop referencing the removed IP HAL header.
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/ctrlm.h | Removes ctrlm_hal_ip.h include and IP init params union member. |
| src/ctrlm_main.cpp | Drops unused ctrlm_hal_ip.h include. |
| src/ble/ctrlm_ble_controller.cpp | Drops unused ctrlm_hal_ip.h include. |
| include/ctrlm_hal_ip.h | Deletes IP HAL public header. |
| doxygen/ctrlm_api_ipc_voice | Removes ctrlm_hal_ip.h from Doxygen exclude patterns list. |
| doxygen/ctrlm_api_ipc_rcu | Removes ctrlm_hal_ip.h from Doxygen exclude patterns list. |
| doxygen/ctrlm_api_ipc_device_update | Removes ctrlm_hal_ip.h from Doxygen exclude patterns list. |
| doxygen/ctrlm_api_ipc | Removes ctrlm_hal_ip.h from Doxygen exclude patterns list. |
| doxygen/ctrlm_api_hal_rf4ce | Removes ctrlm_hal_ip.h from Doxygen exclude patterns list. |
| doxygen/build_docs.py | Removes IP HAL header from doc release packaging and removes docs_gen_hal_ip. |
| CMakeLists.txt | Removes IP_ENABLED option and IP-related compile definitions. |
| ci/cov_build.sh | Removes -DIP_ENABLED=OFF since the option no longer exists. |
egalla204
approved these changes
Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.